HomePhabricator
Diffusion Mesa 816f2dc67da7

i965/miptree: Fix handling of uninitialized MCS buffers

Authored by Nanley Chery <nanley.g.chery@intel.com> on Apr 30 2018, 7:40 PM.

Description

i965/miptree: Fix handling of uninitialized MCS buffers

Before this patch, if we failed to initialize an MCS buffer, we'd
end up in a state in which the miptree thinks it has an MCS buffer,
but doesn't. We also leaked the clear_color_bo if it existed.

With this patch, we now free the miptree aux buffer resources and let
intel_miptree_alloc_mcs() know that the MCS buffer no longer exists.

Cc: <mesa-stable@lists.freedesktop.org>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

Details

Committed
Nanley Chery <nanley.g.chery@intel.com>May 17 2018, 4:06 PM
Pushed
pmoreauMay 22 2018, 7:03 PM
Parents
rMESA1fba2e10b3f3: radv: only declare the ESGS rings for pre GFX9 chips
Branches
Unknown
Tags
Unknown

Event Timeline

Nanley Chery <nanley.g.chery@intel.com> committed rMESA816f2dc67da7: i965/miptree: Fix handling of uninitialized MCS buffers (authored by Nanley Chery <nanley.g.chery@intel.com>).May 17 2018, 4:06 PM