HomePhabricator
Diffusion Mesa 82849fb6d546

i965: Update the indirect buffer in set_clear_color

Authored by Nanley Chery <nanley.g.chery@intel.com> on Apr 8 2018, 11:00 PM.

Description

i965: Update the indirect buffer in set_clear_color

For depth buffers, we avoid fast-clearing if the aux_state is already
CLEAR. We do the same for color buffers only if the clear color
doesn't change. We require that the clear colors match because, in
that case, we don't update the indirect clear color outside of BLORP.

Update the indirect clear color for color buffers as well. We'll
enable the same depth buffer optimization for color buffers in a
later patch.

Note that we're now actually updating the indirect clear color twice
in the case where we use BLORP to perform the fast-clear. This is
only temporary. In later patches, we'll prevent BLORP from performing
the update.

v2: Add more context to the commit message (Topi).

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen@intel.com>

Details

Committed
Nanley Chery <nanley.g.chery@intel.com>May 17 2018, 4:06 PM
Pushed
pmoreauMay 22 2018, 7:03 PM
Parents
rMESA5b315f3ad145: i965/clear: Remove an early return in fast_clear_depth
Branches
Unknown
Tags
Unknown

Event Timeline

Nanley Chery <nanley.g.chery@intel.com> committed rMESA82849fb6d546: i965: Update the indirect buffer in set_clear_color (authored by Nanley Chery <nanley.g.chery@intel.com>).May 17 2018, 4:06 PM